Skip to content

onepassword rate limits on error/not found #4925

@ashtonian

Description

@ashtonian

Describe the bug

onepassword seems to count some weird things as rate limits. I've opened a support ticket with them but I think there may be a better way to handle it here. If the service account token is not in the correct format or not valid, external secrets manager will exhaust the account wide daily rate limits quite rapidly. Also noticed that if external secrets manager is trying to reconcile a password that is not present in the store it will quickly exhaust rate limits. I noticed this when I reinitialized a cluster with the old 1password connect server token instead of the new one.
Exhausted the daily limits within about 20 minutes.

Their rate limits are pretty low ;(

To Reproduce

apiVersion: external-secrets.io/v1
kind: ClusterSecretStore
metadata:
  name: onepassword
spec:
  provider:
    onepasswordSDK:
      vault: myvault
      auth:
        serviceAccountSecretRef:
            name: onepassword-connect-token
            key: token
            namespace: utilities

Expected behavior
If possible, some sort of prevention to stop giving the user more rope.

Screenshots

Additional context

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/1passwordIssues / Pull Requests related to 1password providerarea/onepasswordkind/bugCategorizes issue or PR as related to a bug.kind/performancePerformance-related Pull Requeststrack/providerscapture issues related to providers

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions