Skip to content

Support labels/annotations (all or by regexp/list) being ignored and not trigger update. #3979

@angelh-kr

Description

@angelh-kr

Is your feature request related to a problem? Please describe.
Using eso with flux, gcp config sync or any similar solution causes external secrets to be updated even when no changes are made to the resource because some annotation (like the git ref) is maintained as an annotation/label.

This is especially problematic when using generators like webhook or password.
Webhook is being invoked, or password refreshed with every commit.

Describe the solution you'd like
Add an annotation or spec to control the behavior: Which annotations or labels can trigger an update.
It could be at controller level, or per external secret.

Describe alternatives you've considered

Additional context
I'm forced to leverage immutable secrets, making impossible to have any interval refresh.
And facing problems if secret name needs to be constant (cannot change) with the normal issues around immutable secrets deletion and reuse of the same name.
Right now my solution is using eso to create the secret with a suffix that changes if we need to recreate it, and reflector (other controller) to mirror it to the standard name (without suffix)

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/featureCategorizes issue or PR as related to a new feature.track/coreCaptures issues that are related to Core controller worktriage/supportIndicates an issue that is a support question.

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions