Skip to content

feat: support pkcs12 with chain in pushsecret to Azure KeyVault #3745

@mysteq

Description

@mysteq

Is your feature request related to a problem? Please describe.

Currently you can use "pemToPkcs12" function in a PushSecret template to upload a cert-manager generated certificate to Azure KeyVault. However that creates a pkcs12 without the proper certificate chain. The new function in #3494 called "fullPemToPkcs12" on the other hand creates a pkcs12 with the proper certificate chain, however the Azure KeyVault provider fails to validate this pkcs12 due to the use of gopkcs12.Decode.

Describe the solution you'd like

Change gopkcs12.Decode to gopkcs12.DecodeChain, or add an additional 4th verification that uses gopkcs12.DecodeChain, in https://github.com/external-secrets/external-secrets/blob/main/pkg/provider/azure/keyvault/keyvault.go#L346

Describe alternatives you've considered

No alternatives considered.

Additional context

N/A.

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/featureCategorizes issue or PR as related to a new feature.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions