Skip to content

GithubApp CRD is not installed through Kustomize #3448

@ljtfreitas

Description

@ljtfreitas

Describe the bug

Hi 👋 ,

I would like to use the generator introduced in this PR: #3115

But the CRD file was not included in the kustomization.yaml file, so this one is not included when CRDs are installed through Kustomize.

To Reproduce

Running the suggested command from docs:

kubectl apply -k "https://github.com/external-secrets/external-secrets//config/crds/bases?ref=v0.9.16"

It will be possible to see the GithubAccessToken was not installed.

Additional context

I just included the generators.external-secrets.io_githubaccesstokens.yaml in the kustomization.yaml, in my local environment, and the problem was solved. I opened a PR with the change: #3446

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugCategorizes issue or PR as related to a bug.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions