Skip to content

Webhook provider support HTTP 304 not modified status code #2824

@mannbiher

Description

@mannbiher

Is your feature request related to a problem? Please describe.
I am using Webhook provider to pull data from an internally developed config-management application. The application sends HTTP-304 status code when it verifies the ETag header is not changed. However, current webhook provider considers 304 status as error and continues retrying.
The only workaround I have is to not send the ETag header and keep getting same data which is not changed. This puts unnecessary load on the our config-management application.

Describe the solution you'd like
Change WebHook provider to respect 304 status code. When 304 status is received, provider should simply do nothing except updating the last sync metadata.

Describe alternatives you've considered
The only alternative is to not send ETag data and receive full secret every-time.

Additional context
NA

Metadata

Metadata

Assignees

Labels

good first issueGood for newcomerskind/featureCategorizes issue or PR as related to a new feature.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions