Conversation
|
Well done! |
|
@sergio-tao |
|
Hello! Is there a 4.x release planned that will include this fix soon? Thanks! |
|
Could we please have a patch version for express containing this? |
|
@serhalp @jaenster A fresh To update: (The body-parser update may not be needed depending on your version, but older versions of body-parser had qs pinned so it's good to include.) It occurs to me though that I may be too used to managing dependencies this way to understand why others want to solve it with a patch release. Why do you ask for a patch release? Is there something causing you pain here that a patch would solve? Tooling yelling at you? |
|
That works if you use qs and body-parser directly. But, we dont, we use nestjs express, which uses express, which uses these. But, i might be that im the inexperienced idiot here, so please teach me if im doing it wrong and can solve it without an override. Context, we use pnpm. |
Nest v10.4.22 includes updates to
pnpm has |
|
@jonchurch I don't understand. Why was this "backported" to 4.x if you aren't releasing it? What was the purpose? 🤔 |
|
I might be missing something, but it isn't possible to install express v4 at the moment without 2 high CVEs, unless one uses I think it's actually because of the pinned |
|
The backport is intended to ensure that the next Express 4 release includes this patch, you should already have the patch if you update body-parser as well. This isn’t applied automatically, but if you update body-parser alongside Express, you’ll get it, since Express 4 now uses the ~ notation in its dependencies ( Line 37 in 12fae14 If that’s not the case, then @expressjs/express-captains, we should update the body-parser version here to point to the latest 1.x release (if we haven’t already) and cut a new release. I’ve noticed it’s been difficult for people to get the patch, and I also think something changed in how this works (@krzysdz, I believe you have some context on that). |
|
If you do a "fresh install" (no If you already had Express installed then |
Port for #6969