Fix error where property 'value' does not exist on type 'ValidationError’#794
Merged
gustavohenke merged 2 commits intoexpress-validator:masterfrom Nov 24, 2019
Merged
Conversation
This fixes the error when accessing property 'value' in union object type 'ValidationError’ for properties not defined on all union members.
a7be566 to
f4b7399
Compare
Contributor
Author
|
@gustavohenke could you please review this PR when you are free? Thanks! |
Member
gustavohenke
left a comment
There was a problem hiding this comment.
I made a slight change for type safety. How does it look?
Contributor
Author
|
Looks good to me, thanks for the improvement for type safety. @gustavohenke |
gustavohenke
approved these changes
Nov 24, 2019
Member
|
Shipped in v6.3.0! |
This was referenced Jan 6, 2020
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What went wrong?
Accessing property in union of object types fails for properties not defined on all union members.
Proposed Fix
Add optional types to all validation error fields for each union member. Fixes #795.
Related Issue
microsoft/TypeScript#12815
Environment
TypeScript v3.7.2