Skip to content

feat(ulid): ULID validation #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fedeci merged 9 commits into from
Feb 13, 2024
Merged

feat(ulid): ULID validation #1248

fedeci merged 9 commits into from
Feb 13, 2024

Conversation

@arafatkn
Copy link
Contributor

@arafatkn arafatkn commented Sep 29, 2023 •
edited
Loading

Description

Added validation for ULID (Universally Unique Lexicographically Sortable Identifier).

Read more details on ULID in github:ulid/spec
ULID Generator and validations on https://ulid.page

To-do list

  • Updated readme
  • I have added tests for what I changed.
  • This pull request is ready to merge.

gustavohenke
gustavohenke reviewed Oct 2, 2023
View reviewed changes
@coveralls
Copy link

coveralls commented Oct 7, 2023 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling e12e28e on arafatkn:feat/is-ulid
into db126c7 on express-validator:master.

fedeci
fedeci requested changes Oct 10, 2023
View reviewed changes
Copy link
Member

@fedeci fedeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @arafatkn! Can you please add a couple tests in the validators-impl.spec.ts file? If you need any help please ping me!

arafatkn and others added 2 commits December 25, 2023 18:29
@arafatkn arafatkn requested a review from fedeci December 25, 2023 12:31
@arafatkn arafatkn requested a review from gustavohenke January 16, 2024 14:38
fedeci
fedeci approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@fedeci fedeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for late response

@fedeci fedeci merged commit ffd7994 into express-validator:master Feb 13, 2024
@yunji0387 yunji0387 mentioned this pull request Jun 9, 2024
Merged
@lianghua1987 lianghua1987 mentioned this pull request Jun 9, 2024
Open
@David-Besse David-Besse mentioned this pull request Jun 9, 2024
Merged
@RajeswarSharma RajeswarSharma mentioned this pull request Jun 9, 2024
Open
@turnerrainer turnerrainer mentioned this pull request Jun 9, 2024
Open
@1994dsp 1994dsp mentioned this pull request Jun 9, 2024
Open
@TuanNB28 TuanNB28 mentioned this pull request Jun 9, 2024
Open
@Evahhhh Evahhhh mentioned this pull request Jun 10, 2024
Open
@HarisAwais HarisAwais mentioned this pull request Jun 10, 2024
Open
@papers76 papers76 mentioned this pull request Jun 10, 2024
Open
@shivtej1201 shivtej1201 mentioned this pull request Jun 10, 2024
Open
@ThatsRajeev ThatsRajeev mentioned this pull request Jun 16, 2024
Closed
@Mihinr Mihinr mentioned this pull request Jun 20, 2024
Open
@Type-Style Type-Style mentioned this pull request Jun 27, 2024
Merged
@tristenwallace tristenwallace mentioned this pull request Jul 5, 2024
Merged
@arafatkn arafatkn deleted the feat/is-ulid branch July 6, 2024 02:13
This was referenced Aug 2, 2024
Merged
Merged
@CarlosMHF CarlosMHF mentioned this pull request Aug 4, 2024
Open
This was referenced Sep 2, 2024
Merged
Merged
@LikithaSupreeth LikithaSupreeth mentioned this pull request Sep 2, 2024
Open
@yunji0387 yunji0387 mentioned this pull request Sep 2, 2024
Merged
@Type-Style Type-Style mentioned this pull request Sep 2, 2024
Merged
@Zwiqler94 Zwiqler94 mentioned this pull request Sep 2, 2024
Closed
@KDONJS KDONJS mentioned this pull request Sep 2, 2024
Open
@surajit03 surajit03 mentioned this pull request Sep 2, 2024
Open
@David-Besse David-Besse mentioned this pull request Sep 13, 2024
Closed
This was referenced Sep 18, 2024
Open
Open
@IUdantha IUdantha mentioned this pull request Sep 22, 2024
Open
@IzzyDotExe IzzyDotExe mentioned this pull request Oct 5, 2024
Open
@GeorginaTS GeorginaTS mentioned this pull request Oct 20, 2024
Closed
@SHuan004 SHuan004 mentioned this pull request Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fedeci fedeci fedeci approved these changes

@gustavohenke gustavohenke Awaiting requested review from gustavohenke

Assignees

No one assigned

Labels

PR: new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arafatkn @coveralls @gustavohenke @fedeci