[workspace] feat: improve setup instructions for contributing #271
Conversation
4bb6f6a to
3962e5c
Compare
|
Hey @altaywtf, thanks for bringing up the issues you have encountered, and updating setup a bit! 👍 I'm not a big fan of version files approach, since we don't use them anywhere in Expo repos, let's revert that part. The rest of changes looks great tho! 👌 In near future, I would look at migrating Orbit monorepo to the latests Yarn Berry, there should not be any blockers on this repo, in contrast to the core one. I can also make sure that Node versions are aligned across the codebase. |
thanks @Simek, appreciate your review. would you like me to remove how are we gonna make tools like updated the PR btw, would u mind having another look? |
3962e5c to
75bf318
Compare
75bf318 to
b7bf714
Compare
Simek
left a comment
There was a problem hiding this comment.
Thanks for all of the updates! 👌
Approving already, just one more nit about recommended way to instal pods for menubar app.
Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
Why
As a recent contributor, I encountered some difficulty in determining the precise versions required to run the project. This PR aims to address this issue by adding version files and providing detailed instructions in the documentation.
How
.node-versionand.ruby-versionfiles to respective directories.packageManagertopackage.json.node,ruby/bundler, andcocoapods.lockfilesaccordingly.nodeversion from the.node-versionfile.Test Plan
asdfwithasdf-nodeandasdf-rubyplugins, it's helping a lot for managing these tools with different versions. You may consider giving a try.nvm,fnm,rbenvshould also work similarly.