[workspace] update ESLint setups, bump TypeScript #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldonadel
approved these changes
May 19, 2025
Member
gabrieldonadel
left a comment
There was a problem hiding this comment.
LGTM, thanks for updating this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I have spotted few warning related to miss-matched ESLint parsers and TS versions, and a lack of basic lint setup in packages declaring
eslint-config-universeas dev dependency.How
Update ESLint setups, bump ESLint,
eslint-config-universeand TypeScript versions. Add missing configuration files for few packages, introduce workspace levellintcommand. Fix all newly reported warnings, update workflow to include lint steps.Test Plan
yarn lintin workspace root should work and pass.yarn lintin menu bar app should not yield any errors/warnings.Preview