Rename launch-snack command to launch-expo-go and allow specifying SDK version
#241
+119
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Cedric van Putten <github@cedric.dev>
launch-snack command to launch-expo-go and allow specifying SDK version
996264f to
096765c
Compare
Co-authored-by: Cedric van Putten <github@cedric.dev>
096765c to
b78d0d5
Compare
alanjhughes
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Based on #240 due to an ongoing, but not yet released, project.
We should make the processes of launching projects in Expo Go more generic, not limited by only supporting Snack, and to accomplish this we should also support specifying an SDK version that we want expo go to use.
How
launch-snackcommand tolaunch-expo-goexpo-orbit:///go/?url=xxx&sdkVersion=x.x.xTest Plan
Run menu-bar locally and update unit tests
e.g.
expo-orbit:///go?url=exp%3A%2F%2Fstaging-u.expo.dev%2F2dce2748-c51f-4865-bae0-392af794d60a%3Fruntime-version%3Dexposdk%253A51.0.0%26channel-name%3Dproduction%26snack-channel%3DswDinWIXg1&sdkVersion=52.0.0