[menu-bar] Migrate WebAuthenticationSession module to expo-modules and add electron support #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
343f0c1 to
21001c7
Compare
alanjhughes
approved these changes
Feb 16, 2024
apps/menu-bar/modules/web-authentication-session/ios/WebAuthenticationSessionModule.swift
Outdated
Show resolved
Hide resolved
apps/menu-bar/modules/web-authentication-session/ios/WebAuthenticationSessionModule.swift
Outdated
Show resolved
Hide resolved
apps/menu-bar/modules/web-authentication-session/ios/WebAuthContextProvider.swift
Outdated
Show resolved
Hide resolved
apps/menu-bar/modules/web-authentication-session/ios/WebAuthContextProvider.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Alan Hughes <30924086+alanjhughes@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes ENG-11327
How
Test Plan
Screen.Recording.2024-02-14.at.18.33.04.mov
Screen.Recording.2024-02-14.at.18.38.05.mov