Skip to content

[menu-bar] Add PlatformColor support for electron #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gabrieldonadel merged 2 commits into from
Feb 9, 2024
Merged

[menu-bar] Add PlatformColor support for electron #165

gabrieldonadel merged 2 commits into from
Feb 9, 2024

Conversation

@gabrieldonadel
Copy link
Member

@gabrieldonadel gabrieldonadel commented Feb 6, 2024 •
edited
Loading

Why

Close ENG-11333

How

  • Add global styles to react-native-web mimicking macOS Semantic Colors
  • Add PlatformColor support for electron by converting semantic color strings into CSS variable values

Test Plan

Light Dark
Screenshot 2024-02-09 at 14 54 33 Screenshot 2024-02-09 at 14 54 44
image image

@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/electron-platform-color branch 4 times, most recently from eb2b69e to 9b55bf8 Compare February 6, 2024 02:51
Base automatically changed from @gabrieldonadel/electron-checkbox to main February 6, 2024 12:36
@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/electron-platform-color branch from 9b55bf8 to ff17de6 Compare February 6, 2024 16:19
@linear
Copy link

linear bot commented Feb 6, 2024

ENG-11333 Fix Platform color on Electron/Web

@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/electron-platform-color branch from ff17de6 to 8db50f4 Compare February 9, 2024 17:17
@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/electron-platform-color branch from 8db50f4 to e6ef148 Compare February 9, 2024 17:46
@gabrieldonadel gabrieldonadel marked this pull request as ready for review February 9, 2024 18:31
@gabrieldonadel gabrieldonadel merged commit ec52e9d into main Feb 9, 2024
@gabrieldonadel gabrieldonadel deleted the @gabrieldonadel/electron-platform-color branch February 9, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alanjhughes alanjhughes alanjhughes approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gabrieldonadel @alanjhughes