Skip to content

[video] Remove the allowsFullscreen prop#41606

Merged
behenate merged 2 commits intomainfrom
@behenate/video/remve-allows-fullscreen
Jan 9, 2026
Merged

[video] Remove the allowsFullscreen prop#41606
behenate merged 2 commits intomainfrom
@behenate/video/remve-allows-fullscreen

Conversation

@behenate
Copy link
Copy Markdown
Member

Why

We have been displaying the warning about allowsFullscreen being deprecated for the duration of the SDK 54 cycle. We can now remove it for SDK 55.

How

Remove allowsFullscreen (replaced by a field in fullscreenOptions)

Also removed the following check from VideoView.web.tsx

      if (!props.allowsFullscreen || !videoRef.current) {
        return;
      }

This is because on Android and iOS we don't block the enterFullscreen method when fullscreenOptions.enable is false - the docs state that it only influences the UI element in the native controls.

Test Plan

Tested on android, ios and web(chrome)

@behenate behenate requested a review from tsapeta December 12, 2025 16:08
@github-actions
Copy link
Copy Markdown
Contributor

Subscribed to pull request

File Patterns Mentions
packages/expo-video/** @lukmccall, @aleqsio

Generated by CodeMention

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Dec 12, 2025
@behenate behenate force-pushed the @behenate/video/fix-enable-fullscreen branch from 6149d8a to 2dadc7c Compare January 8, 2026 23:16
@behenate behenate force-pushed the @behenate/video/remve-allows-fullscreen branch from 2c64922 to 78ffb25 Compare January 8, 2026 23:20
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jan 8, 2026
@behenate behenate force-pushed the @behenate/video/fix-enable-fullscreen branch from 2dadc7c to 8cbe8b4 Compare January 9, 2026 11:16
Base automatically changed from @behenate/video/fix-enable-fullscreen to main January 9, 2026 11:16
@behenate behenate force-pushed the @behenate/video/remve-allows-fullscreen branch from 78ffb25 to 097616f Compare January 9, 2026 11:31
@behenate behenate merged commit c4720d5 into main Jan 9, 2026
9 checks passed
@behenate behenate deleted the @behenate/video/remve-allows-fullscreen branch January 9, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot: fingerprint compatible bot: passed checks ExpoBot has nothing to complain about

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants