[video] Remove the allowsFullscreen prop#41606
Merged
Conversation
Contributor
|
Subscribed to pull request
Generated by CodeMention |
tsapeta
approved these changes
Dec 12, 2025
lukmccall
approved these changes
Dec 15, 2025
6149d8a to
2dadc7c
Compare
2c64922 to
78ffb25
Compare
2dadc7c to
8cbe8b4
Compare
78ffb25 to
097616f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We have been displaying the warning about
allowsFullscreenbeing deprecated for the duration of the SDK 54 cycle. We can now remove it for SDK 55.How
Remove allowsFullscreen (replaced by a field in
fullscreenOptions)Also removed the following check from
VideoView.web.tsxThis is because on Android and iOS we don't block the
enterFullscreenmethod whenfullscreenOptions.enableisfalse- the docs state that it only influences the UI element in the native controls.Test Plan
Tested on android, ios and web(chrome)