Merged
Conversation
Collaborator
|
The Pull Request introduced fingerprint changes against the base commit: 6972cea Fingerprint diff[
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../node_modules/@react-native-masked-view/masked-view",
"reasons": [
"rncoreAutolinkingAndroid",
"rncoreAutolinkingIos"
],
"hash": "b7bc27de23ba01de8e9c8a4e566902fd2ba7716e"
},
"afterSource": {
"type": "dir",
"filePath": "../../node_modules/@react-native-masked-view/masked-view",
"reasons": [
"rncoreAutolinkingAndroid",
"rncoreAutolinkingIos"
],
"hash": "8cdd4a863dcde0be3d195b04b3d90937b7543482"
}
},
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-ui/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "460db4cad2570128bda3948b3ecab04c57f322f7"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-ui/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "fd1cd5db419d1119732429d623543429b70c2027"
}
}
]Generated by PR labeler 🤖 |
Kudo
commented
Nov 13, 2025
| LinearProgressIndicator( | ||
| color = composeColor, | ||
| trackColor = trackColor, | ||
| modifier = Modifier.fromExpoModifiers(props.modifiers.value) |
Contributor
Author
There was a problem hiding this comment.
add missing modifiers support for the linear progress view
Contributor
|
Subscribed to pull request
Generated by CodeMention |
intergalacticspacehighway
approved these changes
Nov 14, 2025
| } | ||
| } | ||
| ProgressVariant.CIRCULAR_WAVY -> | ||
| AutoSizingComposable(shadowNodeProxy) { |
Contributor
There was a problem hiding this comment.
are we planning to use AutoSizingComposable for Compose components, or are we adding matchContents support in the Compose's Host?
2b2b6b4 to
511abfe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
close ENG-18029
How
CircularWavyProgressandLinearWavyProgressfor jetpack-composeTest Plan
update ncl example:
Screen_recording_20251113_211550.mp4
Checklist
changelog.mdentry and rebuilt the package sources according to this short guidenpx expo prebuild& EAS Build (eg: updated a module plugin).