docs: Updates new-architecture.mdx flashlist issue#31423
Merged
amandeepmittal merged 1 commit intoexpo:mainfrom Sep 11, 2024
Merged
docs: Updates new-architecture.mdx flashlist issue#31423amandeepmittal merged 1 commit intoexpo:mainfrom
amandeepmittal merged 1 commit intoexpo:mainfrom
Conversation
amandeepmittal
approved these changes
Sep 11, 2024
Member
amandeepmittal
left a comment
There was a problem hiding this comment.
Thank you for your contribution @Maker-Mark 🎉
Member
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The current docs has a grammar issue on the Flashlist section. When fixing the issue, I found out that Flashlist now does support the new architecture (see Shopify/flash-list#550 released in v1.7.0 on July 4th) and propose this line item be removed from the docs.
How
I removed the note about FlashList.
Test Plan
N/A
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).