[tools][ios] Fix unversioned REACT_NATIVE_PATH env#25261
Merged
gabrieldonadel merged 1 commit intomainfrom Nov 8, 2023
Merged
Conversation
Kudo
approved these changes
Nov 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Upgrading to react-native 0.73 revealed an issue with the
REACT_NATIVE_PATHenv value when runningpod installfor Expo Go. This problem happens due to the order thatuse_react_native(unversioned) anduse_versioned_abis!are invoked.use_versioned_abis!is invoked afteruse_react_native, given that it is only inside theExpo Go (versioned)target, causing theREACT_NATIVE_PATHenv to beversioned-react-native/ABI49_0_0/ReactNativeinstead of'../react-native-lab/react-native/packages/react-native'and resulting in codegen generatingrncoreheaders in the wrong folderMaking this env value ABI-specific should fix this problem
Necessary for #24971
How
Update the versioning script to replace all occurrences of
REACT_NATIVE_PATHTest Plan
Run Expo Go Versioned
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).