Skip to content

[tools][ios] Fix unversioned REACT_NATIVE_PATH env#25261

Merged
gabrieldonadel merged 1 commit intomainfrom
@gabrieldonadel/fix-versioning
Nov 8, 2023
Merged

[tools][ios] Fix unversioned REACT_NATIVE_PATH env#25261
gabrieldonadel merged 1 commit intomainfrom
@gabrieldonadel/fix-versioning

Conversation

@gabrieldonadel
Copy link
Copy Markdown
Member

Why

Upgrading to react-native 0.73 revealed an issue with the REACT_NATIVE_PATH env value when running pod install for Expo Go. This problem happens due to the order that use_react_native(unversioned) and use_versioned_abis! are invoked.

use_versioned_abis! is invoked after use_react_native, given that it is only inside the Expo Go (versioned) target, causing the REACT_NATIVE_PATH env to be versioned-react-native/ABI49_0_0/ReactNative instead of '../react-native-lab/react-native/packages/react-native' and resulting in codegen generating rncore headers in the wrong folder

image

Making this env value ABI-specific should fix this problem

Necessary for #24971

How

Update the versioning script to replace all occurrences of REACT_NATIVE_PATH

Test Plan

Run Expo Go Versioned

Checklist

@gabrieldonadel gabrieldonadel requested a review from Kudo November 8, 2023 04:06
@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Nov 8, 2023
@gabrieldonadel gabrieldonadel marked this pull request as ready for review November 8, 2023 04:12
@gabrieldonadel gabrieldonadel merged commit 04d276c into main Nov 8, 2023
@gabrieldonadel gabrieldonadel deleted the @gabrieldonadel/fix-versioning branch November 8, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot: passed checks ExpoBot has nothing to complain about

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants