feat: separate Expo Web & Metro types from router#24255
Merged
Conversation
ENG-9978 Split the typed environment feature out of typed routes
|
Contributor
Author
|
Spoke with Evan, moving both to |
94cfeac to
c0aab13
Compare
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
5d28c94 to
eb71b12
Compare
EvanBacon
approved these changes
Sep 11, 2023
tsapeta
approved these changes
Sep 12, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ENG-9978
Expo Router included TypeScript definitions for Expo Web and Metro. I'm not 100% sure the best place to move these types too, so I'm open to suggestions.
expofor Expo Web, as there is no Expo Web package and these are global environment types.@expo/metro-config. Its a bit weird putting these types in the config package, but this is also where a lot of the related code is.How
Test Plan
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).