Skip to content

fix(config-plugins): default to ['dangerous'] sort order when using unknown platforms#22224

Merged
byCedric merged 3 commits intomainfrom
@bycedric/cli/prebuild-improve-custom-platform
Apr 21, 2023
Merged

fix(config-plugins): default to ['dangerous'] sort order when using unknown platforms#22224
byCedric merged 3 commits intomainfrom
@bycedric/cli/prebuild-improve-custom-platform

Conversation

@byCedric
Copy link
Copy Markdown
Member

@byCedric byCedric commented Apr 21, 2023

Why

Follow-up of #22201

How

When using arbitrary platforms, like foobar, the sort order is not defined. This results in errors like:

image

Instead, this change adds a default sorting order of ['dangerous'] when using arbitrary platforms.

Test Plan

This should not fail as the screenshot above.

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Apr 21, 2023
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Apr 21, 2023
@byCedric byCedric merged commit ed94abb into main Apr 21, 2023
@byCedric byCedric deleted the @bycedric/cli/prebuild-improve-custom-platform branch April 21, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot: passed checks ExpoBot has nothing to complain about

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants