Move to a Nat-based statically-sized vector #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
This looks really useful. The place to change would be https://github.com/expipiplus1/vulkan/blob/master/generate/src/Write/TypeConverter.hs#L99 Thanks! |
Owner
|
I've started a little library for this as it's not really vulkan specific https://github.com/expipiplus1/vector-sized vulkan 1.1 is now using vector-sized. Thanks for the head start with this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was quite curious to know how much of an improvement this would bring so I gave it a quick try. This is quite hacked, brought just far enough to measure the improvement (which is significant, with compilation taking on the order of seconds and an orders of magnitude reduction in compiler allocations). That being said, you might find it to be a useful start. My next step would probably be to provide a
Data.Vector.Storable.Sizedmodule which exports a type synonym,and perhaps reexport the remainder of
Data.Vector.Generic.Sized. You could also do the same for the remaining vector varieties.