Add unidirectional patterns for immutable vectors (#85) #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Define pattern synonyms - `Empty` for matching on zero length vectors - `:<|` for matching on the head and tail of a non-empty vector - `:|>` for matching on the init and last of a non-empty vector in `Vector.Generic.Sized` mimicking 'Data.Sequence'. * Additionally export helpers `snoc` and `unsnoc`. * Re-export specialised versions from - `Vector.Sized` - `Vector.Unboxed.Sized` - `Vector.Storable.Sized`
Owner
|
Sorry it took a while to get to this. I think that we'll merge #88 instead, it supports O(n) construction and does generate warnings for incorrect length matches. I think that having #88 It doesn't however support deconstructing a vector into the initial and last elements. This could be added with a pattern synonym for build potentially, although I think GHC would demand an exact match on the type... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define pattern synonyms
Emptyfor matching on zero length vectors:<|for matching on the head and tail of a non-empty vector:|>for matching on the init and last of a non-empty vectorin
Vector.Generic.SizedmimickingData.Sequence.Additionally export helpers
snocandunsnoc.Re-export specialised versions from
Vector.SizedVector.Unboxed.SizedVector.Storable.Sized