Skip to content

Rename private __FUNCTION__ macro#47

Merged
Thecarisma merged 3 commits intoexoticlibraries:mainfrom
MarcelInTO:main
Mar 10, 2021
Merged

Rename private __FUNCTION__ macro#47
Thecarisma merged 3 commits intoexoticlibraries:mainfrom
MarcelInTO:main

Conversation

@MarcelInTO
Copy link
Copy Markdown
Contributor

  • Rename private FUNCTION macro to CESTER_FUNCTION to prevent…warning on MSVC compilers

  • Use Microsoft's built-in FUNCTION macro if it's available and func is not

… warning on MSVC compilers

- Use Microsoft's builtin __FUNCTION__ macro if it's available and __func__ is not
- Reduce warning spam when using MSVC compiler
… that cause problems if they are included before std headers that use the min and max keywords (eg <limits>). In general, including windows.h causes a lot of problems to cross platform code being compiled on windows and some projects go to great lengths to avoid it. I would love to see it gone entirely from the test framework.
@TheEccentricity
Copy link
Copy Markdown

Hello @MarcelInTO apologies for the late reply, I have been logged out by guthub and I don't have access to my 2fa device anymore.

When you say "windows.h causes lot of problems to cross platform code" and "would love to see it gone entirely from the test framework"

What do you intend to see go from the test framework, windows.h or the problems related to cross platform builds

@TheEccentricity
Copy link
Copy Markdown

Good fix on the FUNCTION I also tried to avoid overriding the compiler defined macros, but that skip my mind.

I ll be sure to merge this as soon as I can.

@MarcelInTO
Copy link
Copy Markdown
Contributor Author

MarcelInTO commented Mar 10, 2021 via email

@Thecarisma
Copy link
Copy Markdown
Member

Thecarisma commented Mar 10, 2021 via email

@Thecarisma Thecarisma merged commit 24281d3 into exoticlibraries:main Mar 10, 2021
@Thecarisma
Copy link
Copy Markdown
Member

Thecarisma commented Mar 12, 2021 via email

@Thecarisma
Copy link
Copy Markdown
Member

Thecarisma commented Mar 12, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants