Introducing CESTER_NO_TIME#14
Merged
Thecarisma merged 4 commits intoexoticlibraries:masterfrom Jun 9, 2020
Merged
Conversation
Member
|
Great works from your side, getting cester to work properly on PlayStation 1 that interesting 👍. Please add a unit test in the test folder with CESTER_NO_TIME macro defined so I can see its behavior. |
15618a5 to
e80f0f0
Compare
Contributor
Author
|
Done. PTAL. |
Thecarisma
reviewed
Jun 9, 2020
Member
|
It is good to merge now. Looking forward to more contributions from you. 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one is potentially a bit controversial.
I've been trying to make cester fit into microcontrollers (see http://www.uc-sdk.net/), and it's not unusual that (1) there is no proper time keeping on these machines and (2) there is no floating point support.
This change introduces
CESTER_NO_TIME, which disables all time keeping features of cester. Activating it will make it so the code will not try to (1) use time functions and (2) use doubles. If the platform that the user is targeting lacks either of these, they can easily disable the feature in order to make their tests work.I'm almost there getting cester to work properly on PlayStation 1 :-)