Simplify migration and make it extensible #1444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our migration tests used strings in Rust files (for exo and SQL), which required string escaping, prefix stripping, and other modifications. This made reading the test code difficult. Also, we relied on exact string matches, which required paying too much attention to the precise format. This refactoring: 1. Move .exo and .sql files outside of rust code 2. Uses `sqlparser` to match without considering the format Note that in some cases, `sqlparser` doesn't parse valid syntax, so we rely on exact string comparison as a fallback/optimization. We will contribute fixes to `sqlparser` and then remove this reliance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our migration tests used strings in Rust files (for exo and SQL), which required string escaping, prefix stripping, and other modifications. This made reading the test code difficult. Also, we relied on exact string matches, which required paying too much attention to the precise format.
This refactoring:
sqlparserto match without considering the formatNote that in some cases,
sqlparserdoesn't parse valid syntax, so we rely on exact string comparison as a fallback/optimization. We will contribute fixes tosqlparserand then remove this reliance.