Batch cleanup#1649
Merged
rltakashige merged 3 commits intoleo/prepare-batch-implementationfrom Mar 3, 2026
Merged
Conversation
Evanev7
commented
Mar 2, 2026
Comment on lines
-87
to
+124
| MpSender[GenerationResponse], | ||
| Generator[GenerationResponse], | ||
| SendableGenerator[GenerationResponse], | ||
| Generator[GenerationResponse | ToolCallResponse | None], |
Member
Author
There was a problem hiding this comment.
commenting ahead of time; the first generator is for the raw GenerationResponses from mlx_generate - for compat with batching - the second is to send them into the processing pipeline, the third is for processed responses.
d922fa6 to
df3b7e6
Compare
f6eccf1 to
6962838
Compare
e919358
into
leo/prepare-batch-implementation
2 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what da ya think!