Skip to content

grep: replace failure with anyhow#971

Merged
coriolinus merged 2 commits intomasterfrom
grep-replace-failure-with-anyhow
Oct 5, 2020
Merged

grep: replace failure with anyhow#971
coriolinus merged 2 commits intomasterfrom
grep-replace-failure-with-anyhow

Conversation

@coriolinus
Copy link
Copy Markdown
Member

The failure crate is getting old, and has largely been superseded
in the ecosystem by the anyhow crate, which better uses the standard
library (and which only became possible with Rust v1.34). We should
demonstrate more modern techniques to students.

See:

The `failure` crate is getting old, and has largely been superseded
in the ecosystem by the `anyhow` crate, which better uses the standard
library (and which only became possible with Rust v1.34). We should
demonstrate more modern techniques to students.

See:

- bytecodealliance/wasmtime#436
- https://blog.yoshuawuyts.com/error-handling-survey/
- https://internals.rust-lang.org/t/failure-crate-maintenance/12087
@elektronaut0815
Copy link
Copy Markdown
Contributor

Ah, didn't see your PR. Well, it was a good exercise for me.

@coriolinus
Copy link
Copy Markdown
Member Author

To reviewers: it may make more sense to look at each commit individually.

@ghost ghost self-assigned this Oct 5, 2020
@ghost
Copy link
Copy Markdown

ghost commented Oct 5, 2020

Great idea to point out using anyhow! I cursorily reviewed the changes and they look good to me.

@ghost ghost self-requested a review October 5, 2020 18:42
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@coriolinus coriolinus merged commit a268661 into master Oct 5, 2020
@coriolinus coriolinus deleted the grep-replace-failure-with-anyhow branch October 5, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants