Modernize packaging and improve Sphinx 9 compatibility#214
Closed
dprada wants to merge 2 commits intoexecutablebooks:mainfrom
Closed
Modernize packaging and improve Sphinx 9 compatibility#214dprada wants to merge 2 commits intoexecutablebooks:mainfrom
dprada wants to merge 2 commits intoexecutablebooks:mainfrom
Conversation
Member
|
Could you enable edits my maintainers here, please? I got to this package in my circle of releasing sphinx9 compatible versions and don't want to repeat your work, but some adjustments are needed here and for the sake of efficiency I would like to just directly work with it. |
Member
|
I'm closing this as a sphinx related changes has been cherry-picked into another PR and I'm cutting a release now. Next time, please enable maintainer access to your branch, so failures can be fixed and things can be merged from the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR applies a minimal, backward-compatible update to improve installation and Sphinx 9 compatibility:
pyproject.tomlwithsetuptools.build_meta(PEP 517/660 editable installs)BuildEnvironment.appaccess in directives (Sphinx 9 deprecation path to Sphinx 11)rinohtypePDF test skip gracefully whenTex Gyre Herosis not available in the environmentWhy
setup.py develop) with modern setuptools/pipself.env.appValidation
sphinx-build -nW --keep-going -b html docs/ ...with Sphinx 9.1pytest -qlocally (with test dependencies installed)Additional note (fork-only validation)
As an additional validation step in my fork, I published a conda package to the
uibcdfchannel with versionv3.4.8to verify the end-to-end packaging/install flow.This conda release workflow/devtools setup is fork-specific and not part of this upstream PR.