Remove no longer needed declare_namespace()#177
Remove no longer needed declare_namespace()#177foster999 merged 1 commit intoexecutablebooks:masterfrom kloczek:master
Conversation
This fix removes declare_namespace() which is no longer needed. it used old style namespaces which has been using `pkg_resources` module which is part of the `setuptools` and which is as well depreceted now. Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #177 +/- ##
==========================================
- Coverage 97.27% 97.26% -0.02%
==========================================
Files 2 2
Lines 220 219 -1
==========================================
- Hits 214 213 -1
Misses 6 6
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Thanks, I hadn't come across this before and wasn't aware that it was redundant. Tests are all passing 👍🏻 |
|
Congrats on your first merged pull request in this project! 🎉 |
|
Thank you 👍 😄 |
This fix removes declare_namespace() which is no longer needed. it used old style namespaces which has been using
pkg_resourcesmodule which is part of thesetuptoolsand which is as well depreceted now.