🐛 FIX: Fix to stop stripping of first line in MyST content#163
Closed
reiyw wants to merge 1 commit intoexecutablebooks:masterfrom
Closed
🐛 FIX: Fix to stop stripping of first line in MyST content#163reiyw wants to merge 1 commit intoexecutablebooks:masterfrom
reiyw wants to merge 1 commit intoexecutablebooks:masterfrom
Conversation
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
Collaborator
|
Thanks for this change @reiyw, I hadn't realised this was different in MyST vs rST Does the nested_parse strip off the blank line from rST? |
Contributor
Author
Collaborator
|
Once I've merged #164 we can rerun the tests here to confirm it doesn't break any tested rST behaviour |
Collaborator
|
pre-commit.ci run |
Collaborator
|
Created #165 to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This pull request fixes a problem where the first line of content in a
taborgroup-tabdirective is stripped in MyST.The following in MyST will render with the first line in the
tabandgroup-tabblocks stripped.The cause of this is the index specification when getting the directive content within the
TabDirective.runmethod.sphinx-tabs/sphinx_tabs/tabs.py
Line 187 in 0b04c8e
The directive syntax in reStructuredText requires a blank line before the content, so
self.content[1]is guaranteed to be a blank line. However, MyST has no such restriction; the actual content starts fromself.content[1]when written as in the example above. Therefore, if one slices it asself.content[2:], the first line of the content will be stripped.So, I modified it so that the first line of content is parsed in MyST by slicing the content from
[1:]. I think that this change does not affect the parsing of content in reStructuredText.