Skip to content

Fix test_other_with_assets_new_style w/Sphinx 4.0#133

Merged
foster999 merged 1 commit intoexecutablebooks:masterfrom
befeleme:patch-1
Aug 5, 2021
Merged

Fix test_other_with_assets_new_style w/Sphinx 4.0#133
foster999 merged 1 commit intoexecutablebooks:masterfrom
befeleme:patch-1

Conversation

@befeleme
Copy link
Copy Markdown
Contributor

@befeleme befeleme commented Aug 5, 2021

Make the test work with Sphinx 4.0.x. (It was skipped when testing with 4.0.2)
Fix the typo so that the regression file is actually found - it threw FileNotFoundError once the condition was corrected.

@befeleme
Fix test_other_with_assets_new_style w/Sphinx 4.0
ce36c78 
Make the test work with Sphinx 4.0.x.
Fix the typo so that the regression file is actually found.
@welcome
Copy link
Copy Markdown

welcome bot commented Aug 5, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 5, 2021

Codecov Report

Merging #133 (ce36c78) into master (f3cf8a9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #133   +/-   ##
=======================================
  Coverage   92.23%   92.23%           
=======================================
  Files           2        2           
  Lines         219      219           
=======================================
  Hits          202      202           
  Misses         17       17
Flag Coverage Δ
pytests 92.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3cf8a9...ce36c78. Read the comment docs.

@foster999
Copy link
Copy Markdown
Collaborator

foster999 commented Aug 5, 2021

Good spot, thanks for fixing this!

@foster999 foster999 merged commit 0f185f4 into executablebooks:master Aug 5, 2021
@welcome
Copy link
Copy Markdown

welcome bot commented Aug 5, 2021

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@befeleme befeleme deleted the patch-1 branch August 6, 2021 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@befeleme @foster999