Fix parsing for unsupported builders, including rinohtype (for pdf)#103
Merged
Fix parsing for unsupported builders, including rinohtype (for pdf)#103
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #103 +/- ##
==========================================
+ Coverage 94.08% 97.10% +3.01%
==========================================
Files 1 1
Lines 203 207 +4
==========================================
+ Hits 191 201 +10
+ Misses 12 6 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
027a28a to
918bb16
Compare
Collaborator
|
I'll review and test with my groups documentation in a few hours |
Collaborator
Author
|
Thanks, that would be really useful as the test example is quite minimal 👍🏻 |
Collaborator
|
Seems to build and look fine on my teams PDF https://github.com/wpilibsuite/frc-docs/suites/1985343336/artifacts/39545658 |
Daltz333
approved these changes
Feb 7, 2021
Collaborator
Author
|
Great, thanks for giving it a try |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now uses base docutils classes when builder is unsupported, rather than custom sphinx-tabs nodes.
Added test for successful building with
rinohtype. This includes regression testing of the XML, but not the output pdf. Turns out pdf's are quite awkward to diff!Fixes #99