Skip to content

Conversation

@chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Aug 15, 2022

  • add CI tests against build html, latex and man
  • Fix visits to fontawesome nodes, and add warning for non-supported formats

fixes #87

@codecov-commenter
Copy link

Codecov Report

Merging #88 (235de2c) into main (8c486be) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main      #88   +/-   ##
=======================================
  Coverage   88.98%   88.98%           
=======================================
  Files          11       11           
  Lines         917      917           
=======================================
  Hits          816      816           
  Misses        101      101           
Flag Coverage Δ
pytests 88.98% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sphinx_design/icons.py 80.62% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chrisjsewell chrisjsewell changed the title 🐛 FIX: fontawesome latex builds 🐛 FIX: Docs build against non-html formats Aug 15, 2022
@chrisjsewell chrisjsewell merged commit f309aee into main Aug 15, 2022
@chrisjsewell chrisjsewell deleted the fix-fontawesome branch August 15, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pdf-builder fails with "KeyError: 'icon_name'" when in conf.py 'sd_fontawesome_latex = True' is set

3 participants