ENH: Make default blue color a11y friendly. #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default blue of #007bff is often on white backgrounds. In this case the contrast ration is about 3.97. This means that it is considered inaccessible based on the W3C WCAG standard. Update to be a slightly darker blue by default, thus making the design more accessible without further customizing. See https://developer.mozilla.org/en-US/docs/Web/Accessibility/Understanding_WCAG/Perceivable/Color_contrast for more context.
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
for more information, see https://pre-commit.ci
choldgraf
approved these changes
Apr 6, 2023
Member
choldgraf
left a comment
There was a problem hiding this comment.
Makes sense to me - I think we want to keep the defaults a11y-friendly so I'll merge this one
|
Congrats on your first merged pull request in this project! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default blue of #007bff is often on white backgrounds. In this case the contrast ration is about 3.97. This means that it is considered inaccessible based on the W3C WCAG standard. Update to be a slightly darker blue by default, thus making the design more accessible without further customizing.
See https://developer.mozilla.org/en-US/docs/Web/Accessibility/Understanding_WCAG/Perceivable/Color_contrast for more context.