fix: Add missing width, class-img-top, class-img-bottom options to grid-item-card#115
Merged
choldgraf merged 2 commits intoexecutablebooks:mainfrom Apr 13, 2023
jpmckinney:109-fix-missing-grid-item-card-options
Merged
fix: Add missing width, class-img-top, class-img-bottom options to grid-item-card#115choldgraf merged 2 commits intoexecutablebooks:mainfrom jpmckinney:109-fix-missing-grid-item-card-options
choldgraf merged 2 commits intoexecutablebooks:mainfrom
jpmckinney:109-fix-missing-grid-item-card-options
Conversation
choldgraf
approved these changes
Apr 13, 2023
Member
choldgraf
left a comment
There was a problem hiding this comment.
Seems reasonable to me - thanks for spotting this and adding the patch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #109
Personally I would read from
CardDirective.option_specinstead of requiring a maintainer to manually syncoption_specand that other array, but maybe there was a reason for it.