ENH: make the generated documentation more reproducible#883
Merged
choldgraf merged 1 commit intoexecutablebooks:masterfrom Dec 23, 2024
Merged
ENH: make the generated documentation more reproducible#883choldgraf merged 1 commit intoexecutablebooks:masterfrom
choldgraf merged 1 commit intoexecutablebooks:masterfrom
Conversation
choldgraf
approved these changes
Dec 23, 2024
Member
choldgraf
left a comment
There was a problem hiding this comment.
This all looks reasonable to me - thanks for these improvements to make it a bit more deterministic!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am packaging sphinx-book-theme for Debian, and one of our goals is to make the built packages reproducible. See https://reproducible-builds.org/ for details.
This pull request makes the following improvements:
Use static ID for tables generated by pandas. This removes the following diff:
We have only one table on the page, so we can just hardcode
1. Also, replace deprecatedapplymapwithmap.Use
plt.show()as the final statement of matplotlib blocks, to prevent repr of AxesImage being added to HTML, which causes this diff:Call
np.random.seed(0)before usingnp.random.randn().After these fixes there are still problems coming from Folium and from equation with automatic label, but I have found no good solution, so I will probably just patch them out in Debian.