FIX: .bd-sizebar-secondary and .secondary-toggle breakpoint#809
Merged
agoose77 merged 3 commits intoexecutablebooks:masterfrom Jun 12, 2024
sinsong:master
Merged
FIX: .bd-sizebar-secondary and .secondary-toggle breakpoint#809agoose77 merged 3 commits intoexecutablebooks:masterfrom sinsong:master
.bd-sizebar-secondary and .secondary-toggle breakpoint#809agoose77 merged 3 commits intoexecutablebooks:masterfrom
sinsong:master
Conversation
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
Collaborator
|
This matches my read of the upstream code, which sets |
agoose77
reviewed
Jun 12, 2024
src/sphinx_book_theme/assets/styles/sections/_header-article.scss
Outdated
Show resolved
Hide resolved
.bd-sizebar-secondary and .secondary-toggle breakpoint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My friend find that
.bd-sidebar-secondarycollapse before.secondary-toggleappear. Which means, viewport width between 1200px (xl breakpoint) and 992px (lg breakpoint), both sidebar and toggle button disappear.I find that a rule come from pydata-sphinx-theme interact with
.bd-sidebar-secondarycause collapse less that 1200px (exactly at 1199.98px). With the breakpoint xl.So this PR is for synchronize
.secondary-tooglebutton with.bd-sidebar-secondarycollapse through align breakpoint to xl.