FIX: set bd-docs-nav as a class attribute instead of an id to restore compat with pydata-sphinx-theme JS#754
Merged
choldgraf merged 1 commit intoexecutablebooks:masterfrom Oct 10, 2023
Conversation
…compat with pydata-sphinx-theme JS
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
choldgraf
approved these changes
Oct 10, 2023
Member
choldgraf
left a comment
There was a problem hiding this comment.
Ah yes - this looks good, thanks for noticing and making the PR!
|
Congrats on your first merged pull request in this project! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a partial fix for #541.
It makes the
scrollToActivefunction frompydata-sphinx-theme.jswork as expected on jupyter-book rendered HTML.However, this function does not save the collapsed state of other sections which make the "scroll to saved location" a bit weird/broken at times.
Still, it's already much better than the current state.