Skip to content

add support for gitlab issue button#740

Merged
choldgraf merged 3 commits intoexecutablebooks:masterfrom
akhmerov:gitlab-issue-button
Jul 3, 2023
Merged

add support for gitlab issue button#740
choldgraf merged 3 commits intoexecutablebooks:masterfrom
akhmerov:gitlab-issue-button

Conversation

@akhmerov
Copy link
Copy Markdown
Contributor

@akhmerov akhmerov commented Jun 3, 2023

@akhmerov
Copy link
Copy Markdown
Contributor Author

akhmerov commented Jun 3, 2023

I don't understand the CI failures, and the testing guide doesn't quite help.

EDIT: was my mistake, I figured it out.

@akhmerov akhmerov force-pushed the gitlab-issue-button branch from ab413cb to 4a7a3b6 Compare June 3, 2023 11:28
@akhmerov
Copy link
Copy Markdown
Contributor Author

akhmerov commented Jun 3, 2023

Lighthouse failure seems unrelated, the rest of the tests are passing.

@agoose77
Copy link
Copy Markdown
Collaborator

agoose77 commented Jun 5, 2023

@akhmerov thanks for this! Would you be willing to add some tests for this? Probably looking for something similar to this test

@akhmerov
Copy link
Copy Markdown
Contributor Author

akhmerov commented Jun 5, 2023

I've updated the test, however I can't figure out how to update the reference html files. Do you have any pointers?

@akhmerov akhmerov force-pushed the gitlab-issue-button branch from e351ec1 to 7907803 Compare June 5, 2023 11:19
@akhmerov
Copy link
Copy Markdown
Contributor Author

akhmerov commented Jun 5, 2023

Should be ready now.

@akhmerov
Copy link
Copy Markdown
Contributor Author

Checking so that I don't forget about this PR; @agoose77 can you please take a look if the test is satisfactory?

@akhmerov
Copy link
Copy Markdown
Contributor Author

akhmerov commented Jul 3, 2023

@choldgraf I saw you're bumping versions in the repo. This PR should be rather straightforward and it's ready to merge 🙏 👀

Copy link
Copy Markdown
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks for the ping!

@choldgraf choldgraf merged commit a9794b7 into executablebooks:master Jul 3, 2023
@akhmerov akhmerov deleted the gitlab-issue-button branch July 3, 2023 12:55
@akhmerov akhmerov restored the gitlab-issue-button branch July 3, 2023 14:13
@houqp
Copy link
Copy Markdown

houqp commented Oct 4, 2023

hi, any plan to cut a new release to include this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants