Skip to content

🐛 FIX: :align: for image directive#198

Merged
choldgraf merged 2 commits intoexecutablebooks:masterfrom
najuzilu:fix-img-align
Sep 2, 2020
Merged

🐛 FIX: :align: for image directive#198
choldgraf merged 2 commits intoexecutablebooks:masterfrom
najuzilu:fix-img-align

Conversation

@najuzilu
Copy link
Copy Markdown
Member

This PR fixes the align option for image directives. I have set the default align behavior to center.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 27, 2020

Codecov Report

Merging #198 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #198   +/-   ##
=======================================
  Coverage   91.56%   91.56%           
=======================================
  Files           2        2           
  Lines         237      237           
=======================================
  Hits          217      217           
  Misses         20       20           
Flag Coverage Δ
#pytests 91.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccff278...f09bfd7. Read the comment docs.

@richardliaw
Copy link
Copy Markdown

This would be awesome! Currently trying to port my project to this theme, but running into the issue where images aren't being centered properly.

@choldgraf
Copy link
Copy Markdown
Member

nice! is there someplace in the docs where we show off how people can get this to work, so we confirm that it behaves as expected?

@pradyunsg
Copy link
Copy Markdown
Member

is there someplace in the docs where we show off how people can get this to work, so we confirm that it behaves as expected?

https://sphinx-book-theme.readthedocs.io/en/latest/reference/demo.html#images-figures?

@choldgraf
Copy link
Copy Markdown
Member

Ya but since the default is now center, the page just shows the same alignment 3 times

https://sphinx-book-theme--198.org.readthedocs.build/en/198/reference/demo.html#images-figures

@najuzilu
Copy link
Copy Markdown
Member Author

This documentation should help clarify and test the behavior: https://sphinx-book-theme--198.org.readthedocs.build/en/198/reference/demo.html#images.
FYI, I included a couple <br/>s to make the documentation look nicer but would be happy to remove them if you think that's too much.

@choldgraf choldgraf changed the title Fix :align: for image directive 🐛 FIX: :align: for image directive Sep 2, 2020
@choldgraf choldgraf merged commit b977856 into executablebooks:master Sep 2, 2020
@welcome
Copy link
Copy Markdown

welcome bot commented Sep 2, 2020

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@choldgraf
Copy link
Copy Markdown
Member

perfect! thanks so much @najuzilu :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants