Do not allow blank lines within $$#6
Closed
eric-wieser wants to merge 2 commits intoexecutablebooks:mainfrom
Closed
Do not allow blank lines within $$#6eric-wieser wants to merge 2 commits intoexecutablebooks:mainfrom
eric-wieser wants to merge 2 commits intoexecutablebooks:mainfrom
Conversation
This matches the behavior of LaTeX, and prevents runaway parsing if a $$ is opened but not closed.
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
Contributor
Author
|
@chrisjsewell, would it be psosible for you to take a look at this? |
rowanc1
approved these changes
Jun 22, 2022
Comment on lines
+229
to
+238
| display equation with blank lines. (valid=False) | ||
| . | ||
| $$ | ||
| 1+1=2 | ||
|
|
||
| $$ | ||
| . | ||
| <p>$$1+1=2</p> | ||
| <p>$$</p> | ||
| . |
Member
There was a problem hiding this comment.
Test looks solid, I have run into this on my content as well recently!
Member
|
For some reason the tests won't start: I am going to open another PR and try there. |
Member
|
This has been super-seeded by #8, mostly to get the github actions to actually run. 🤷 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches the behavior of LaTeX (and of the stackexchange and github markdown parsers), and prevents runaway parsing if a $$ is opened but not closed.