Skip to content

👌 IMPROVE: Defaut HTML tags#4

Merged
chrisjsewell merged 4 commits intomainfrom
ref/html-defaults
Sep 9, 2021
Merged

👌 IMPROVE: Defaut HTML tags#4
chrisjsewell merged 4 commits intomainfrom
ref/html-defaults

Conversation

@rowanc1
Copy link
Member

@rowanc1 rowanc1 commented Jul 6, 2021

Changed the default parsing to: <div class="math amsmath">{content}</div>. See #1

Added some tests to cover more realistic AMS math scenarios.

Also in this PR: Added a prettier ignore file, updated the package lock with the peer dependencies.

@welcome
Copy link

welcome bot commented Jul 6, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@rowanc1 rowanc1 changed the base branch from master to main July 6, 2021 04:24
@rowanc1 rowanc1 force-pushed the ref/html-defaults branch from 88130ca to ac1688b Compare July 6, 2021 04:25
@chrisjsewell
Copy link
Member

chrisjsewell commented Jul 6, 2021

I will wait to see the corresponding PR on mdit-py-plugins before approving this 😉

@rowanc1 rowanc1 mentioned this pull request Aug 3, 2021
Merged
@rowanc1 rowanc1 force-pushed the ref/html-defaults branch from ac1688b to e0c1fec Compare August 3, 2021 17:02
@rowanc1
Copy link
Member Author

rowanc1 commented Aug 3, 2021

I will wait to see the corresponding PR on mdit-py-plugins before approving this 😉

The changes have been made in: executablebooks/mdit-py-plugins#27

@rowanc1 rowanc1 mentioned this pull request Aug 5, 2021
Closed
@chrisjsewell chrisjsewell linked an issue Sep 9, 2021 that may be closed by this pull request
Default HTML tags #1
Closed
@chrisjsewell chrisjsewell changed the title 🔧 MAINTAIN: HTML default tags 👌 IMPROVE: Defaut HTML tags Sep 9, 2021
@chrisjsewell chrisjsewell merged commit b4d6c24 into main Sep 9, 2021
@welcome
Copy link

welcome bot commented Sep 9, 2021

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@chrisjsewell chrisjsewell deleted the ref/html-defaults branch September 9, 2021 23:08
@rowanc1
Copy link
Member Author

rowanc1 commented Sep 9, 2021

Nice, thanks for the merge!

@chrisjsewell
Copy link
Member

chrisjsewell commented Sep 9, 2021

I'm bloody on it lol!
Going to try and push through all the JS stuff right now; ah the world has been conspiring against me lol had some heavy "man flu" this week 🤒

If you are mildly interested in what has been keeping me away from EBP, things like this: https://github.com/chrisjsewell/aiida-process-coordinator; basically if you need any help with sockets, or servers, or databases, ... let me know lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Default HTML tags

2 participants

@rowanc1 @chrisjsewell