FIX: fix path suffix condition in core/read.py#641
Merged
bsipocz merged 6 commits intoexecutablebooks:masterfrom Nov 12, 2024
Merged
FIX: fix path suffix condition in core/read.py#641bsipocz merged 6 commits intoexecutablebooks:masterfrom
bsipocz merged 6 commits intoexecutablebooks:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #620 the path suffix operation was updated to fix a warning in sphinx 8. The effect was to only check the last suffix instead of all suffixes as was previously achieved. For a filename
my_example.ex.pyand a custom extension of '.ex.py' the old value ofpath.endswith(suffix)would be true whereasPath.suffixonly returns '.py' therefore will return false here:MyST-NB/myst_nb/core/read.py
Line 71 in 83f8d1b
I've added a test for this but I needed to do quite a bit of playing to get past some of the eccentricities of the test suite. let me know if I need to change anything
The reason for all of this on my end is to distinguish which files I want converted and not all python files in a given directory. For reference see where we do this
https://github.com/Fusion-Power-Plant-Framework/bluemira/blob/develop/documentation/source/conf.py#L130-L135