MAINT: removing version pinnings for testing and rtd#634
Merged
agoose77 merged 3 commits intoexecutablebooks:masterfrom Sep 24, 2024
Merged
MAINT: removing version pinnings for testing and rtd#634agoose77 merged 3 commits intoexecutablebooks:masterfrom
agoose77 merged 3 commits intoexecutablebooks:masterfrom
Conversation
5946b15 to
1cd5bc1
Compare
Member
Author
|
@agoose77 - this is ready for review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will
close #632
close #631
close #573
close #533
close #348
The only remaining one is the mpl pin for the tests as the images generated are mpl version-dependent. I suppose looking into using something a little bit more flexible would be useful (e.g. pytest-mpl probably is the answer)