FIX: output metadata overwrites image size for all following images#609
Merged
agoose77 merged 6 commits intoexecutablebooks:masterfrom Jun 27, 2024
Merged
FIX: output metadata overwrites image size for all following images#609agoose77 merged 6 commits intoexecutablebooks:masterfrom
agoose77 merged 6 commits intoexecutablebooks:masterfrom
Conversation
Contributor
|
@agoose77 see #599 (comment) about the failing tests |
Collaborator
|
This passes all tests, but there are some deployment bugs related to NumPy 2 that we need to address. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #608
A cell-level configuration parameter was retrieved and then modified. Since it is a dictionary, the global configuration was modified. By making a copy of the dictionary, the overrides to the dictionary are only local to this specific cell.
I considered to modify
get_cell_level_configto always return a copy, to avoid future mistakes when using this API. But it actually returns not the whole cell config as dictionary, but the value for a key, which can be any type (bool etc., and only forrender_image_optionsa dictionary).