Skip to content

UPGRADE: Support Sphinx 7#524

Merged
choldgraf merged 3 commits intoexecutablebooks:masterfrom
LecrisUT:sphinx-7
Jun 30, 2023
Merged

UPGRADE: Support Sphinx 7#524
choldgraf merged 3 commits intoexecutablebooks:masterfrom
LecrisUT:sphinx-7

Conversation

@LecrisUT
Copy link
Copy Markdown
Contributor

@LecrisUT LecrisUT commented Jun 18, 2023 •
edited
Loading

There is a dependency hell to resolve here due to the testing requirements. However this package is a blocking requirement for various other packages downstream. These test requirements should be addressed.

See my fork's PR for current status LecrisUT#1

@welcome
Copy link
Copy Markdown

welcome bot commented Jun 18, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@LecrisUT LecrisUT force-pushed the sphinx-7 branch 3 times, most recently from d0aa2e2 to 4d47f95 Compare June 18, 2023 00:52
@LecrisUT LecrisUT mentioned this pull request Jun 19, 2023
Closed
@choldgraf
Copy link
Copy Markdown
Member

choldgraf commented Jun 22, 2023

If you can get all of the tests passing here then I'm happy to take a look and merge. MyST-NB hits a lot of the inner Sphinx machinery and so new Sphinx releases tend to break MyST-NB. The PR with the most activity on getting various versions bumped is here:

@LecrisUT
Copy link
Copy Markdown
Contributor Author

LecrisUT commented Jun 22, 2023

I think it is best to focus on #479 because of Sphinx7 it is mostly dependency issues. I will then rebase on top of that and see what surprises we get from the other CIs. Sounds like a good plan?

@choldgraf
Copy link
Copy Markdown
Member

choldgraf commented Jun 22, 2023

agreed - we need to get this stack upgraded in general and that is a big blocker

@LecrisUT
Copy link
Copy Markdown
Contributor Author

LecrisUT commented Jun 23, 2023

Applied #479 temporarily so we can see the broader tests after that is applied

@LecrisUT
Copy link
Copy Markdown
Contributor Author

LecrisUT commented Jun 23, 2023

Great, everything seems to be working with that branch and in this PR it's only the Sphinx7 dependency issue that I wanted to highlight and address.

jupytext 1.14.6 depends on markdown-it-py<3.0.0 and >=1.0.0
    myst-parser 2.0.0 depends on markdown-it-py~=3.0
    mdit-py-plugins 0.4.0 depends on markdown-it-py<4.0.0 and >=1.0.0

jupytext issue is being slowly handled: mwouts/jupytext#1075

@LecrisUT
Copy link
Copy Markdown
Contributor Author

LecrisUT commented Jun 30, 2023

Jupytext pushed a new version so now all dependencies are satisfied. I restarted rhe CI locally, but found rhat 3.11 is failing

@choldgraf
Copy link
Copy Markdown
Member

choldgraf commented Jun 30, 2023

I've just merged in the MyST-Parser bump, and updated this branch to use it. Just FYI!

@choldgraf choldgraf mentioned this pull request Jun 30, 2023
Closed
@LecrisUT
Copy link
Copy Markdown
Contributor Author

LecrisUT commented Jun 30, 2023

Ok, I'll rebase it. In a sec. Keep an eye out to restart the CI

@LecrisUT
Copy link
Copy Markdown
Contributor Author

LecrisUT commented Jun 30, 2023

Oh, all tests are green on my fork 🤔

choldgraf
choldgraf approved these changes Jun 30, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot! It looks like it is happy :-)

Thanks for this contribution ✨

@choldgraf choldgraf merged commit 51dfdab into executablebooks:master Jun 30, 2023
@welcome
Copy link
Copy Markdown

welcome bot commented Jun 30, 2023

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@LecrisUT
Copy link
Copy Markdown
Contributor Author

LecrisUT commented Jun 30, 2023

Great, anything else before pushing a new tag?

@LecrisUT LecrisUT deleted the sphinx-7 branch June 30, 2023 11:00
@LecrisUT LecrisUT mentioned this pull request Jul 6, 2023
Merged
@agoose77 agoose77 changed the title Support sphinx 7 UPGRADE: Support Sphinx 7 Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@choldgraf choldgraf choldgraf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LecrisUT @choldgraf