Skip to content

📚 DOCS: Fix typos and add codespell pre-commit hook#475

Merged
agoose77 merged 2 commits intoexecutablebooks:masterfrom
myfloss:fix-typos-and-add-codepspell-pre-commit-hook
Aug 23, 2023
Merged

📚 DOCS: Fix typos and add codespell pre-commit hook#475
agoose77 merged 2 commits intoexecutablebooks:masterfrom
myfloss:fix-typos-and-add-codepspell-pre-commit-hook

Conversation

@kianmeng
Copy link
Copy Markdown
Contributor

@kianmeng kianmeng commented Mar 5, 2023

Typos found via codespell -S *.ipynb and typos --format brief.

@kianmeng
📚 DOCS: Fix typos and add codespell pre-commit hook
033c266 
Typos found via `codespell -S *.ipynb` and `typos --format brief`.
@welcome
Copy link
Copy Markdown

welcome bot commented Mar 5, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1aee72d) 81.47% compared to head (5ab092c) 81.47%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #475   +/-   ##
=======================================
  Coverage   81.47%   81.47%           
=======================================
  Files          29       29           
  Lines        2618     2618           
=======================================
  Hits         2133     2133           
  Misses        485      485
Flag Coverage Δ
pytests 81.47% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
myst_nb/sphinx_.py 90.07% <ø> (ø)
myst_nb/core/render.py 85.05% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@agoose77 agoose77 self-requested a review August 23, 2023 09:36
@agoose77
Copy link
Copy Markdown
Collaborator

agoose77 commented Aug 23, 2023

Thanks for this - it's always nice to protect against the inevitable perils of writing.

@agoose77 agoose77 merged commit 35ebd54 into executablebooks:master Aug 23, 2023
@welcome
Copy link
Copy Markdown

welcome bot commented Aug 23, 2023

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@kianmeng
Copy link
Copy Markdown
Contributor Author

kianmeng commented Aug 24, 2023

🥳 🥳 🥳 🥳 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agoose77 agoose77 agoose77 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kianmeng @agoose77 @choldgraf