MAINT: Fix codecov jobs and update pre-commit#460
Merged
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #460 +/- ##
==========================================
- Coverage 81.67% 81.47% -0.21%
==========================================
Files 29 29
Lines 2647 2618 -29
==========================================
- Hits 2162 2133 -29
Misses 485 485
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
810fb66 to
5208c49
Compare
74b5a77 to
2dd9409
Compare
2dd9409 to
22f88f9
Compare
22f88f9 to
ee662b4
Compare
4938ef6 to
3e8afc1
Compare
ea76978 to
5d48a53
Compare
d37abe2 to
80a7a7d
Compare
58b0c4f to
f04dde6
Compare
updates: - [github.com/pre-commit/pre-commit-hooks: v4.3.0 → v4.4.0](pre-commit/pre-commit-hooks@v4.3.0...v4.4.0) - [github.com/asottile/pyupgrade: v3.2.2 → v3.3.1](asottile/pyupgrade@v3.2.2...v3.3.1) - [github.com/PyCQA/isort: 5.10.1 → 5.12.0](PyCQA/isort@5.10.1...5.12.0) - [github.com/psf/black: 22.10.0 → 23.3.0](psf/black@22.10.0...23.3.0) - [github.com/PyCQA/flake8: 5.0.4 → 6.0.0](PyCQA/flake8@5.0.4...6.0.0) - [github.com/pre-commit/mirrors-mypy: v0.990 → v1.2.0](pre-commit/mirrors-mypy@v0.990...v1.2.0)
64060b1 to
f5be1c5
Compare
for more information, see https://pre-commit.ci
choldgraf
previously approved these changes
Apr 11, 2023
choldgraf
approved these changes
Apr 11, 2023
Member
choldgraf
left a comment
There was a problem hiding this comment.
LGTM - also added in a fix for the codecov jobs that were failing as it wasn't working on non-ubuntu systems
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates: