ENH: Adding scroll bars with proper cell tags#454
ENH: Adding scroll bars with proper cell tags#454bsipocz merged 7 commits intoexecutablebooks:masterfrom
Conversation
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #454 +/- ##
==========================================
- Coverage 81.67% 81.63% -0.04%
==========================================
Files 29 29
Lines 2647 2647
==========================================
- Hits 2162 2161 -1
- Misses 485 486 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
chrisjsewell
left a comment
There was a problem hiding this comment.
thanks @dprada have a look at my comment for changes
dprada
left a comment
There was a problem hiding this comment.
This was already solved, right?
The review comments have been addressed.
Some lines were added to mystnb.css to add scroll bars with tags: 'output_scroll', 'scroll-output' and 'scroll-input'.
The lines implemented are similar to the paragraph in https://github.com/executablebooks/sphinx-book-theme/blob/eb1b6baf098b27605e8f2b7b2979b17ebf1b9540/src/sphinx_book_theme/assets/styles/extensions/_myst-nb.scss#L21. The only difference is the inclusion of indications for horizontal bars (width and y lines).
See #453