🔧 MAINT: Pin ipykernel to ~v5.5#347
Conversation
chrisjsewell
left a comment
There was a problem hiding this comment.
Cheers! (Providing the tests now pass)
if you could also open an issue for eventually updating the tests to ipykernel v6 (although I think this has dropped support for python 3.6, so we would also need to drop that)
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
=======================================
Coverage 87.43% 87.43%
=======================================
Files 12 12
Lines 1337 1337
=======================================
Hits 1169 1169
Misses 168 168
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
setup.cfg
Outdated
| pytest-cov~=2.8 | ||
| pytest-regressions | ||
| sympy | ||
| ipykernel~=5.5 |
There was a problem hiding this comment.
one nitpick: can we move this up to be in alphabetical order 😬
|
thanks for the review - I opened up #348 and moved the dep |
830daef to
356b2e9
Compare
|
ok gonna merge this one since we're fixing a failing test on master... |
closes #346