Merged
Conversation
Simplifies the faceted filter actions component by using the Button component and Separator component instead of the Command component. Improves the faceted filter builder by enhancing searchability by including builder titles as keywords. Adds autofocus to the input field in dropdown and multi-select components.
Ensures that the project filter is always present in events views by default. This change ensures that the events, issues and stream pages will always have a default project filter applied when the page loads. It also sets a priority for the project builder in the faceted filter.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the filtering functionality with improved accessibility features and UI consistency. The changes focus on keyboard navigation, screen reader support, and better project filtering across different pages.
- Adds comprehensive keyboard navigation support (Enter/Escape) to filter components
- Improves accessibility with ARIA labels and screen reader friendly help text
- Enhances project filtering by adding ProjectFilter to default filters across multiple pages
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/routes/(app)/stream/+page.svelte | Adds ProjectFilter import and includes empty ProjectFilter in default filters |
| src/routes/(app)/issues/+page.svelte | Adds ProjectFilter import and includes empty ProjectFilter in default filters |
| src/routes/(app)/+page.svelte | Adds ProjectFilter import and includes empty ProjectFilter in default filters |
| src/lib/features/shared/components/faceted-filter/faceted-filter-string.svelte | Adds keyboard navigation, accessibility attributes, and cancel functionality |
| src/lib/features/shared/components/faceted-filter/faceted-filter-number.svelte | Adds keyboard navigation, accessibility attributes, and cancel functionality |
| src/lib/features/shared/components/faceted-filter/faceted-filter-multi-select.svelte | Always shows search input and adds autofocus |
| src/lib/features/shared/components/faceted-filter/faceted-filter-keyword.svelte | Adds keyboard navigation, accessibility attributes, and cancel functionality |
| src/lib/features/shared/components/faceted-filter/faceted-filter-drop-down.svelte | Always shows search input, adds autofocus, and fixes code formatting |
| src/lib/features/shared/components/faceted-filter/faceted-filter-builder.svelte | Adds keyword filter creation from search and improves UI consistency |
| src/lib/features/shared/components/faceted-filter/faceted-filter-boolean.svelte | Replaces text input with radio group interface and adds keyboard navigation |
| src/lib/features/shared/components/faceted-filter/faceted-filter-actions.svelte | Replaces Command components with Button components for better consistency |
| src/lib/features/events/components/filters/organization-defaults-faceted-filter-builder.svelte | Sets priority for ProjectBuilder component |
...Web/ClientApp/src/lib/features/shared/components/faceted-filter/faceted-filter-string.svelte
Outdated
Show resolved
Hide resolved
...Web/ClientApp/src/lib/features/shared/components/faceted-filter/faceted-filter-number.svelte
Outdated
Show resolved
Hide resolved
...eb/ClientApp/src/lib/features/shared/components/faceted-filter/faceted-filter-keyword.svelte
Outdated
Show resolved
Hide resolved
Changes the aria-describedby attribute to reference the "-help" element instead of the "-description" element for improved accessibility. This ensures screen readers correctly associate the button with its help text.
niemyjski
commented
Aug 26, 2025
| {#if options.length > 10} | ||
| <Command.Input placeholder={title} /> | ||
| {/if} | ||
| <Command.Input placeholder={title} autofocus={open} /> |
Member
Author
There was a problem hiding this comment.
if you conditionally show this, then usability goes way down because focus is all kinds of messed up and you can't tab between the components.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.